LuciferYang commented on pull request #35154: URL: https://github.com/apache/spark/pull/35154#issuecomment-1012975206
On the other hand, there is a case can't change: https://github.com/apache/spark/blob/fcc51767aa4a594868eff33a7ddd8c5242006cd8/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ObjectExpressionsSuite.scala#L54-L65 if the `equals` method change to ``` override def equals(other: Any): Boolean = { other match { case inner: Inner => value == inner.value case _ => false } } ``` the UT `SPARK-23584 NewInstance should support interpreted execution` in ObjectExpressionsSuite will failed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
