beliefer commented on a change in pull request #35130:
URL: https://github.com/apache/spark/pull/35130#discussion_r782760381
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/PushDownUtils.scala
##########
@@ -107,14 +107,12 @@ object PushDownUtils extends PredicateHelper {
}
/**
- * Pushes down aggregates to the data source reader
+ * Translate aggregate expressions and group by expressions.
*
- * @return pushed aggregation.
+ * @return translated aggregation.
*/
- def pushAggregates(
- scanBuilder: SupportsPushDownAggregates,
- aggregates: Seq[AggregateExpression],
- groupBy: Seq[Expression]): Option[Aggregation] = {
+ def translateAggregation(
Review comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
