cloud-fan commented on a change in pull request #35130:
URL: https://github.com/apache/spark/pull/35130#discussion_r782782172
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2ScanRelationPushDown.scala
##########
@@ -87,9 +87,26 @@ object V2ScanRelationPushDown extends Rule[LogicalPlan] with
PredicateHelper {
if filters.isEmpty &&
project.forall(_.isInstanceOf[AttributeReference]) =>
sHolder.builder match {
case r: SupportsPushDownAggregates =>
+ val normalizedGroupingExpressions =
DataSourceStrategy.normalizeExprs(
+ groupingExpressions, sHolder.relation.output)
+ val translatedGroupBys =
+ PushDownUtils.translateAggregation(Seq.empty,
normalizedGroupingExpressions)
Review comment:
This assumes the v2 source only need the group by columns to decide if
it supports complete pushdown or not. Do you have strong evidence to indicate
it's true for all v2 sources?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
