cloud-fan commented on a change in pull request #35060:
URL: https://github.com/apache/spark/pull/35060#discussion_r783189547
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/NumberUtils.scala
##########
@@ -164,26 +192,86 @@ object NumberUtils {
val bigDecimal = input.toJavaBigDecimal
val decimalPlainStr = bigDecimal.toPlainString
if (decimalPlainStr.length > transformedFormat.length) {
- transformedFormat.replaceAll("0", "#")
+ transformedFormat.replaceAll("0", POUND_SIGN_STRING)
} else {
- val decimalFormat = new DecimalFormat(transformedFormat)
- var resultStr = decimalFormat.format(bigDecimal)
+ val numberDecimalFormat = {
+ val decimalFormat = new DecimalFormat()
Review comment:
can we do `new DecimalFormat(transformedFormat)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
