cloud-fan commented on a change in pull request #35130:
URL: https://github.com/apache/spark/pull/35130#discussion_r784021016
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2ScanRelationPushDown.scala
##########
@@ -164,25 +188,25 @@ object V2ScanRelationPushDown extends Rule[LogicalPlan]
with PredicateHelper {
Project(projectExpressions, scanRelation)
} else {
val plan = Aggregate(
- output.take(groupingExpressions.length),
resultExpressions, scanRelation)
+ output.take(groupingExpressions.length),
finalResultExpressions, scanRelation)
// scalastyle:off
// Change the optimized logical plan to reflect the pushed
down aggregate
// e.g. TABLE t (c1 INT, c2 INT, c3 INT)
- // SELECT min(c1), max(c1) FROM t GROUP BY c2;
+ // SELECT min(c1), max(c1), avg(c1) FROM t GROUP BY c2;
Review comment:
When we reach here, the AVG translation is already done and it's weird
to see we mention it in the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
