imback82 commented on a change in pull request #35202:
URL: https://github.com/apache/spark/pull/35202#discussion_r784468742
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DropNamespaceExec.scala
##########
@@ -46,9 +46,17 @@ case class DropNamespaceExec(
}
}
- if (!nsCatalog.dropNamespace(ns)) {
- throw
QueryCompilationErrors.cannotDropNonemptyNamespaceError(namespace)
+ nsCatalog match {
+ case v2SessionCatalog: V2SessionCatalog =>
+ if (!v2SessionCatalog.dropNamespaceWithCascadeMode(ns, cascade)) {
Review comment:
> My proposal is to add a new API `dropNamespace(String[] ns, boolean
cascade)` to replace the existing one, and ask the implementation to deal with
the cascade parameter by itself.
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
