Peng-Lei commented on pull request #35204: URL: https://github.com/apache/spark/pull/35204#issuecomment-1014747343
> @Peng-Lei can you be more specific? What's the expectation of the tests and how do we break it? > > I see that we exclude `COMMENT` there, as we do want to allow users to specify the COMMENT property directly. Do we have the same expectation for `EXTERNAL`? If yes, where is the code? expectation of the tests： - if `LEGACY_PROPERTY_NON_RESERVED` == `false`. That means we reserved table properties. so we could not use key of reserved properties for `create/replace table options/tblproperties ...` and `set/unset tblproperties`. so result is throw a ParseException. - if `LEGACY_PROPERTY_NON_RESERVED` == `true`. That means we can use reserved key for `create/replace table options/tblproperties ...` and `set/unset tblproperties`. but have no effect. At first I was really confused why filter `COMMENT` and plan to do a new PR to fix it so that `COMMENT` and `EXTERNAL` are same with other reserved properties key. so modify the code of ASTBuilder.scala first. anthor reason I think `EXTERNAL` is a little special, as is should be consistent with whether the location is defined. But at now, I am wrong. Sorry. I should look more code to keep the same expectation with `COMMENT`. @cloud-fan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
