Peng-Lei commented on pull request #35204: URL: https://github.com/apache/spark/pull/35204#issuecomment-1015060395
> @Peng-Lei We should update `AstBuilder.cleanTableProperties`, to make `EXTERNAL` a truly reserved property. Let's open a new PR for it as it's a breaking change. The [issue](https://issues.apache.org/jira/browse/SPARK-37950?orderby=created+DESC%2C+cf%5B10010%5D+ASC%2C+priority+DESC%2C+updated+DESC) is created. I'm so sorry for spending a lot of your time on review this PR. Thank you very much for your patient code review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
