zero323 commented on a change in pull request #34293:
URL: https://github.com/apache/spark/pull/34293#discussion_r788199973
##########
File path: python/pyspark/streaming/context.py
##########
@@ -264,7 +280,9 @@ def checkpoint(self, directory):
"""
self._jssc.checkpoint(directory)
- def socketTextStream(self, hostname, port,
storageLevel=StorageLevel.MEMORY_AND_DISK_2):
+ def socketTextStream(
+ self, hostname: str, port: int, storageLevel: StorageLevel =
StorageLevel.MEMORY_AND_DISK_2
+ ) -> "DStream[str]":
Review comment:
> We need to wait to inline type hints
`python/pyspark/streaming/dstream.py` and have `DStream(Generic[T_co])` before
use `DStream[str]` directly
Why do say that? `DStream` is already generic within stubs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
