zero323 commented on a change in pull request #34293:
URL: https://github.com/apache/spark/pull/34293#discussion_r788224761
##########
File path: python/pyspark/streaming/context.py
##########
@@ -264,7 +280,9 @@ def checkpoint(self, directory):
"""
self._jssc.checkpoint(directory)
- def socketTextStream(self, hostname, port,
storageLevel=StorageLevel.MEMORY_AND_DISK_2):
+ def socketTextStream(
+ self, hostname: str, port: int, storageLevel: StorageLevel =
StorageLevel.MEMORY_AND_DISK_2
+ ) -> "DStream[str]":
Review comment:
To be precise, for `DStream[T]` you need `DStream` to be runtime
generic. To avoid further rewrites, we can mark them as generics within this
PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
