Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/5843#discussion_r30203180
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala ---
@@ -36,6 +37,36 @@ private[ui] class StagePage(parent: StagesTab) extends
WebUIPage("stage") {
private val progressListener = parent.progressListener
private val operationGraphListener = parent.operationGraphListener
+ private val TIMELINE_LEGEND = {
+ <div class="legend-area">
+ <svg>
+ {
+ val legendPairs = List(("deserialization-time-proportion", "Task
Deserialization Time"),
+ ("shuffle-read-time-proportion", "Shuffle Read Time"),
+ ("executor-runtime-proportion", "Executor Computing Time"),
+ ("shuffle-write-time-proportion", "Shuffle Write Time"),
+ ("serialization-time-proportion", "Result Serialization TIme"),
+ ("getting-result-time-proportion", "Getting Result Time"),
+ ("scheduler-delay-proportion", "Scheduler Delay"))
+
+ legendPairs.zipWithIndex.map {
+ case ((classAttr, name), index) =>
+ <rect x={5 + (index / 3) * 210 + "px"} y={10 + (index % 3) *
15 + "px"}
+ width="10px" height="10px" class={classAttr}></rect>
+ <text x={25 + (index / 3) * 210 + "px"}
+ y={20 + (index % 3) * 15 + "px"}>{name}</text>
+ }
+ }
+ </svg>
+ </div>
+ }
+
+ // scalastyle:off
+ // TODO: We should consider increasing the number of this parameter over
time if we find that it's okey.
--- End diff --
Instead of using scalastyle exception, just break the comment into two
lines. Also "okay" instead of "okey".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
