dchvn commented on a change in pull request #35202:
URL: https://github.com/apache/spark/pull/35202#discussion_r791526891
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
##########
@@ -1235,7 +1235,7 @@ class HiveDDLSuite
if (tableExists && !cascade) {
assertAnalysisError(
sqlDropDatabase,
- s"Cannot drop a non-empty database: $dbName.")
+ s"Cannot drop a non-empty namespace: $dbName.")
Review comment:
Updated. Could you please take a look? Sorry about my mistake, I
reversed the test of `HiveDDLSuite`. Do we still need to add a new API to
`CatalogPlugin`: `namespaceAlias`? @cloud-fan
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
##########
@@ -1235,7 +1235,7 @@ class HiveDDLSuite
if (tableExists && !cascade) {
assertAnalysisError(
sqlDropDatabase,
- s"Cannot drop a non-empty database: $dbName.")
+ s"Cannot drop a non-empty namespace: $dbName.")
Review comment:
The above snippet calls `dropDatabase` in `HiveExternalCatalog`,
throwing `QueryCompilationErrors.cannotDropNonemptyDatabaseError(db)`. This was
included in [#PR 35007](https://github.com/apache/spark/pull/35007). @cloud-fan
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/DropNamespaceSuite.scala
##########
@@ -28,7 +28,8 @@ import org.apache.spark.sql.execution.command
* - V1 In-Memory catalog:
`org.apache.spark.sql.execution.command.v1.DropNamespaceSuite`
* - V1 Hive External catalog:
`org.apache.spark.sql.hive.execution.command.DropNamespaceSuite`
*/
-trait DropNamespaceSuiteBase extends command.DropNamespaceSuiteBase {
+trait DropNamespaceSuiteBase extends command.DropNamespaceSuiteBase
Review comment:
It uses `DROP NAMESPACE ... CASCADE` tests that extend with
`DropNamespaceSuiteBase`.
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/DropNamespaceSuite.scala
##########
@@ -28,7 +28,8 @@ import org.apache.spark.sql.execution.command
* - V1 In-Memory catalog:
`org.apache.spark.sql.execution.command.v1.DropNamespaceSuite`
* - V1 Hive External catalog:
`org.apache.spark.sql.hive.execution.command.DropNamespaceSuite`
*/
-trait DropNamespaceSuiteBase extends command.DropNamespaceSuiteBase {
+trait DropNamespaceSuiteBase extends command.DropNamespaceSuiteBase
Review comment:
It uses `DROP NAMESPACE ... CASCADE` test included in
`DropNamespaceSuiteBase`, which it extends with, right @cloud-fan ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
