ueshin commented on a change in pull request #35296:
URL: https://github.com/apache/spark/pull/35296#discussion_r791057545
##########
File path: python/pyspark/pandas/generic.py
##########
@@ -889,6 +889,7 @@ def to_json(
lines: bool = True,
partition_cols: Optional[Union[str, List[str]]] = None,
index_col: Optional[Union[str, List[str]]] = None,
+ ignoreNullFields: bool = False,
Review comment:
If we go with the additional parameter, shall we use the keyword-only
parameter as @zero323 suggested at
https://github.com/apache/spark/pull/35296#discussion_r790685881, but with a
snake case parameter name to be more pythonic?
```py
def to_json(
...,
*,
ignore_null_fields: bool = False,
**options) -> ...
```
Then use the original name when merging to `options`.
##########
File path: python/pyspark/pandas/generic.py
##########
@@ -904,7 +905,7 @@ def to_json(
.. note:: output JSON format is different from pandas'. It always use
`orient='records'`
for its output. This behaviour might have to change in the near
future.
-
+
Review comment:
nit: could you revert this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
