zero323 commented on a change in pull request #35296:
URL: https://github.com/apache/spark/pull/35296#discussion_r795046478
##########
File path: python/pyspark/pandas/generic.py
##########
@@ -980,6 +983,9 @@ def to_json(
"""
if "options" in options and isinstance(options.get("options"), dict)
and len(options) == 1:
options = options.get("options")
+
+ default_options: Dict[str, Any] = {"ignoreNullFields": False}
+ options = {**default_options, **options}
Review comment:
> Now flake8 print F821 undefined name 'Dict'
That's because you didn't import `Dict` from `typing` (please note that it
is `Dict` not `dict`).
You have to add it after `Callable`.
https://github.com/apache/spark/blob/d992250d93b16ac5301c6b0a0456cad31bddd76b/python/pyspark/pandas/generic.py#L24-L26
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
