mridulm commented on a change in pull request #34122:
URL: https://github.com/apache/spark/pull/34122#discussion_r792761973
##########
File path: core/src/main/scala/org/apache/spark/Dependency.scala
##########
@@ -135,6 +144,7 @@ class ShuffleDependency[K: ClassTag, V: ClassTag, C:
ClassTag](
def shuffleMergeId: Int = _shuffleMergeId
def setMergerLocs(mergerLocs: Seq[BlockManagerId]): Unit = {
+ assert(shuffleMergeEnabled || shuffleMergeAllowed)
Review comment:
Yes, when we want it to be disabled (like with retry of DETERMINATE
stage which was already finalized), we must set merge allowed to false. It is
cleaner.
Note - `def isShuffleMergeEnabled` or `def shuffleMergeEnabled` pointing to
`mergerLocs.nonEmpty` is fine (and preferred to using mergerLocs.<foo>) - we
just dont need the state boolean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
