mridulm commented on a change in pull request #34122:
URL: https://github.com/apache/spark/pull/34122#discussion_r793836705
##########
File path: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
##########
@@ -2608,8 +2608,12 @@ private[spark] class DAGScheduler(
// isPushBasedShuffleEnabled and shuffleMergers need to be updated at the
end.
stage match {
case s: ShuffleMapStage =>
-
stage.latestInfo.setPushBasedShuffleEnabled(s.shuffleDep.getMergerLocs.nonEmpty)
- stage.latestInfo.setShuffleMergerCount(s.shuffleDep.getMergerLocs.size)
+ val isPushShuffleEnabled =
+ s.shuffleDep.shuffleMergeAllowed &&
s.shuffleDep.getMergerLocs.nonEmpty
Review comment:
When will we have the case where mergerLocs is non empty, but merge is
not allowed ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
