Yikun edited a comment on pull request #35359: URL: https://github.com/apache/spark/pull/35359#issuecomment-1024830371
@dcoliversun > What do you think about this？ Now that we can implement one that avoids potential attacks, why not? IMO, please make sure [SPARK-37713](https://issues.apache.org/jira/browse/SPARK-37713) is valid or not? Then we continue to this disccussion. - (I think it is) If it's invalid, I prefer to revert. #35299 - If it's valid, I prefer to set configmap namespace separtely , #35215 - (neutrals for me) If it's valid, and also think namespace in confFileMap thing it's a good design and not a potential security issue (yep, @dongjoon-hyun PR address this and let conf.namespace overwrite the map), just merge this PR. > I think the namespace in sparkConf will prevail. Yes, so the user passed `spark.kubernetes.namespace` would be ignored. and I updated my comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
