dcoliversun commented on pull request #35359: URL: https://github.com/apache/spark/pull/35359#issuecomment-1024854370
> @dcoliversun Now that we can implement one that avoids potential attacks, why not? > > IMO, please make sure [SPARK-37713](https://issues.apache.org/jira/browse/SPARK-37713) is valid or not? Then we continue to this disccussion. > > * (I think it is) If it's invalid, I prefer to revert. [[SPARK-37916][SPARK-37713][K8S] Revert "Assign namespace to executor configmap" #35299](https://github.com/apache/spark/pull/35299) > * If it's valid, I prefer to set configmap namespace separtely , [[SPARK-37916][K8S] The ConfigMap is assigned to incorrect namespace #35215](https://github.com/apache/spark/pull/35215) > * If it's valid, and also think namespace in confFileMap thing it's not a potential security issue (note that user can enable cutom feature step ), just merge @dongjoon-hyun this PR I think [SPARK-37713](https://issues.apache.org/jira/browse/SPARK-37713) is valid because explicitly namespace propagation can avoid interception or modification for `.metadata.namespace`. I prefer to merge this PR for insufficient namespace propagation. @dongjoon-hyun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
