thesamet commented on a change in pull request #35378:
URL: https://github.com/apache/spark/pull/35378#discussion_r797309161
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
##########
@@ -371,6 +384,18 @@ case class Invoke(
}
private lazy val encodedFunctionName =
ScalaReflection.encodeFieldNameToIdentifier(functionName)
+ private var isDeterministic: Boolean = true
Review comment:
The intent of the suggestion was to do this on or after the 3.3.0
release. It's ok to defer, but binary incompatibilities between 3.2.x and 3.3.0
are more expected. This is just to balance how long you want to carry the noise
in the code caused by the additional constructors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
