HyukjinKwon commented on a change in pull request #35378:
URL: https://github.com/apache/spark/pull/35378#discussion_r798170142
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
##########
@@ -254,6 +254,20 @@ case class StaticInvoke(
returnNullable: Boolean = true,
isDeterministic: Boolean = true) extends InvokeLike {
+ // This additional constructor is added to keep binary compatibility after
the addition of the
Review comment:
This is an internal API, and I think it makes less sense to make some
changes to keep the binary compatibility here. We should probably mention
maintenance release too - note that they were all explicitly `private[sql]`
before (which we removed this accessor at SPARK-16813 to make the code easier
to debug easier). Such compatibility has never been guaranteed in history.
One option might be to revert https://github.com/apache/spark/pull/35243
since it is trivial up to my knowledge, and it virtually doesn't affect
anything by default in Spark 3.2.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
