dongjoon-hyun commented on a change in pull request #35345:
URL: https://github.com/apache/spark/pull/35345#discussion_r797335081
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesDriverBuilder.scala
##########
@@ -38,8 +40,27 @@ private[spark] class KubernetesDriverBuilder {
.getOrElse(SparkPod.initialPod())
val userFeatures = conf.get(Config.KUBERNETES_DRIVER_POD_FEATURE_STEPS)
- .map { className =>
-
Utils.classForName(className).newInstance().asInstanceOf[KubernetesFeatureConfigStep]
+ .map { className => {
+ val feature = Utils.classForName[Any](className).newInstance()
+ val initializedFeature = feature match {
+ // Since 3.3, allow user implements feature with KubernetesDriverConf
Review comment:
`allow user implements` -> `allow user to implement`?
There are other places with the same pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
