dongjoon-hyun commented on a change in pull request #35345:
URL: https://github.com/apache/spark/pull/35345#discussion_r797341836
##########
File path:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/PodBuilderSuite.scala
##########
@@ -66,6 +72,57 @@ abstract class PodBuilderSuite extends SparkFunSuite {
assert(pod.container.getVolumeMounts.asScala.exists(_.getName ==
"so_long_two"))
}
+ test("SPARK-37145: configure a custom test step with base config") {
+ val client = mockKubernetesClient()
+ val sparkConf = baseConf.clone()
+ .set(userFeatureStepsConf.key,
+ "org.apache.spark.deploy.k8s.TestStepWithConf")
+ .set(templateFileConf.key, "template-file.yaml")
+ .set("test-features-key", "test-features-value")
+ val pod = buildPod(sparkConf, client)
+ verifyPod(pod)
+ val metadata = pod.pod.getMetadata
+ assert(metadata.getAnnotations.containsKey("test-features-key"))
+ assert(metadata.getAnnotations.get("test-features-key") ===
"test-features-value")
+ }
+
+ test("SPARK-37145: configure a custom test step with driver or executor
config") {
+ val client = mockKubernetesClient()
+ val (featureSteps, annotation) = userFeatureStepWithExpectedAnnotation
+ val sparkConf = baseConf.clone()
+ .set(templateFileConf.key, "template-file.yaml")
+ .set(userFeatureStepsConf.key, featureSteps)
+ .set(TEST_ANNOTATION_KEY, annotation)
+ val pod = buildPod(sparkConf, client)
+ verifyPod(pod)
+ val metadata = pod.pod.getMetadata
+ assert(metadata.getAnnotations.containsKey(TEST_ANNOTATION_KEY))
+ assert(metadata.getAnnotations.get(TEST_ANNOTATION_KEY) === annotation)
+ }
+
+ test("SPARK-37145: configure a custom test step with wrong type config") {
+ val client = mockKubernetesClient()
+ val sparkConf = baseConf.clone()
+ .set(templateFileConf.key, "template-file.yaml")
+ .set(userFeatureStepsConf.key, wrongTypeFeatureStep)
+ val e = intercept[SparkException] {
+ buildPod(sparkConf, client)
+ }
+ assert(e.getMessage.contains("Failed to initialize feature step"))
Review comment:
Shall we use more specific error message like `please make sure your
driver side feature steps` instead of this neutral one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
