kazuyukitanimura commented on a change in pull request #35393:
URL: https://github.com/apache/spark/pull/35393#discussion_r799981350
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/vectorized/ArrowColumnVector.java
##########
@@ -130,9 +130,16 @@ public ColumnarMap getMap(int rowId) {
@Override
public ArrowColumnVector getChild(int ordinal) { return
childColumns[ordinal]; }
+ ArrowColumnVector(DataType type) {
Review comment:
Thanks. My intention was to allow sub classes to override the
constructor so that the subclass constructor can do more stuff before calling
`initAccessor`. At least that is my use case.
The subclasses can choose to override `initAccessor` or the subclass
constructor can directly assign the `accessor`.
Is your idea for `public ArrowColumnVector(ArrowVectorAccessor accessor)`
more for using ArrowColumnVector as is rather than extending?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
