kazuyukitanimura commented on a change in pull request #35393:
URL: https://github.com/apache/spark/pull/35393#discussion_r801259527
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/vectorized/ArrowColumnVectorSuite.scala
##########
@@ -431,4 +430,35 @@ class ArrowColumnVectorSuite extends SparkFunSuite {
columnVector.close()
allocator.close()
}
+
+ test ("SPARK-38086: subclassing") {
+ class ChildArrowColumnVector(vector: ValueVector, n: Int)
+ extends ArrowColumnVector(vector: ValueVector) {
+
+ override def getValueVector: ValueVector = accessor.vector
+ override def getInt(rowId: Int): Int = accessor.getInt(rowId) + n
+ }
+
+ val allocator = ArrowUtils.rootAllocator.newChildAllocator("int", 0,
Long.MaxValue)
+ val vector = ArrowUtils.toArrowField("int", IntegerType, nullable = true,
null)
+ .createVector(allocator).asInstanceOf[IntVector]
+ vector.allocateNew()
+
+ (0 until 10).foreach { i =>
+ vector.setSafe(i, i)
+ }
+
+ val columnVector = new ChildArrowColumnVector(vector, 1)
+ assert(columnVector.dataType === IntegerType)
+ assert(!columnVector.hasNull)
+
+ val intVector = columnVector.getValueVector.asInstanceOf[IntVector]
+ (0 until 10).foreach { i =>
+ assert(columnVector.getInt(i) === i + 1)
+ intVector.get(i) === i + 1
Review comment:
Sorry, I meant to `assert` here as I am testing the `getValueVector`.
Updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
