cloud-fan commented on a change in pull request #35378:
URL: https://github.com/apache/spark/pull/35378#discussion_r800355435
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
##########
@@ -254,6 +254,20 @@ case class StaticInvoke(
returnNullable: Boolean = true,
isDeterministic: Boolean = true) extends InvokeLike {
+ // This additional constructor is added to keep binary compatibility after
the addition of the
Review comment:
AFAIK this is always case by case. Yes, we don't expect people to rely
on private classes such as `Expression`, but the fact is many Spark libraries
are already using these private classes.
The ecosystem is very important to Spark and I think we should try our best
to fix binary compatibility if it does break downstream libraries. I'm +1 to
this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
