dongjoon-hyun commented on a change in pull request #35444:
URL: https://github.com/apache/spark/pull/35444#discussion_r802151142
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Canonicalize.scala
##########
@@ -42,7 +42,7 @@ object Canonicalize {
/** Remove names and nullability from types, and names from
`GetStructField`. */
private[expressions] def ignoreNamesTypes(e: Expression): Expression = e
match {
case a: AttributeReference =>
- AttributeReference("none", a.dataType.asNullable)(exprId = a.exprId)
+ AttributeReference("none", a.dataType)(exprId = a.exprId)
Review comment:
The same comment on the branch-3.2 PR. We should update line 42 to be
consistent.
```
- Remove names and nullability from types
+ Remove names from types
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
