shardulm94 commented on a change in pull request #35444:
URL: https://github.com/apache/spark/pull/35444#discussion_r802171093
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala
##########
@@ -1502,4 +1502,24 @@ class AdaptiveQueryExecSuite
}
}
}
+
+ test("SPARK-38030: Query with cast containing non-nullable columns should
succeed with AQE") {
Review comment:
We encountered this issue in production when running Spark 3.1.1.
However, this repro does not work on 3.2+. This is because the code which would
previously trigger access on an unresolved object is [now
lazy](https://github.com/apache/spark/blob/7e5c3b216431b6a5e9a0786bf7cded694228cdee/sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/ShuffleExchangeExec.scala#L132)
and hence does not trigger the issue in 3.2+, although the root cause still
existed in 3.2+. So I only added this test in 3.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
