HyukjinKwon commented on a change in pull request #35415:
URL: https://github.com/apache/spark/pull/35415#discussion_r802429480
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
##########
@@ -2538,6 +2538,56 @@ case class Encode(value: Expression, charset: Expression)
newLeft: Expression, newRight: Expression): Encode = copy(value = newLeft,
charset = newRight)
}
+/**
+ * Converts the input expression to a binary value based on the supplied
format.
+ */
+// scalastyle:off line.size.limit
+@ExpressionDescription(
+ usage = """
+ _FUNC_(str[, fmt]) - Converts the input `str` to a binary value based on
the supplied `fmt`.
+ By default, the binary format for conversion is "hex" if `fmt` is
omitted.
+ """,
+ examples = """
+ Examples:
+ > SELECT _FUNC_('abc', 'utf-8');
+ abc
+ """,
+ since = "3.3.0",
+ group = "string_funcs")
+// scalastyle:on line.size.limit
+case class ToBinary(expr: Expression, format: Option[Expression], child:
Expression)
+ extends RuntimeReplaceable {
+
+ def this(expr: Expression, format: Expression) = this(expr, Option(format),
+ format.toString match {
+ case "hex" => Unhex(expr)
+ case "utf-8" => Encode(expr, Literal("UTF-8"))
+ case "base64" => UnBase64(expr)
+ case "base2" => Cast(expr, BinaryType)
+ }
+ )
Review comment:
Yeah, `Literal("hex")` creates a literal with internal data.
`Literal(UTFString("hex"), StringType)`. Actually, this is a good point. I
think we should do this something like:
```scala
format match {
case lit: Literal if lit.dataType == StringType => lit.eval() match {
case "hex" => ...
}
case other => ...
}
```
or
```scala
format match {
case lit if lit.foldable => lit.eval() match {
case "hex" => ...
}
case other => ...
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
