dongjoon-hyun commented on a change in pull request #34659:
URL: https://github.com/apache/spark/pull/34659#discussion_r803324113
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileBasedDataSourceTest.scala
##########
@@ -52,7 +54,8 @@ private[sql] trait FileBasedDataSourceTest extends
SQLTestUtils {
f(spark.read.format(dataSourceName).load(path.toString))
}
if (testVectorized) {
- withSQLConf(vectorizedReaderEnabledKey -> "true") {
+ withSQLConf(vectorizedReaderEnabledKey -> "true",
+ vectorizedReaderNestedEnabledKey -> "true") {
Review comment:
Could you revise the test framework to have a complete test coverage for
both `true` and `false`, @sunchao ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
