dongjoon-hyun commented on a change in pull request #34659:
URL: https://github.com/apache/spark/pull/34659#discussion_r803330689
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetUtils.scala
##########
@@ -144,6 +145,30 @@ object ParquetUtils {
file.getName == ParquetFileWriter.PARQUET_METADATA_FILE
}
+ /**
+ * Whether columnar read is supported for the input `schema`.
+ */
+ def isBatchReadSupportedForSchema(sqlConf: SQLConf, schema: StructType):
Boolean =
Review comment:
It would be great to design new functions minimally which receive the
minimal information instead of passing over the full `SQLConf` recursively. For
example, could you revise
- `isBatchReadSupportedForSchema` by handing over the values of
`sqlConf.parquetVectorizedReaderEnabled` and
`sqlConf.parquetVectorizedReaderNestedColumnEnabled`
- `isBatchReadSupported` by handing over the value of
`sqlConf.parquetVectorizedReaderNestedColumnEnabled` from
`isBatchReadSupportedForSchema`.
directly instead of `SQLConf` recursively?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
