sunchao commented on a change in pull request #35483:
URL: https://github.com/apache/spark/pull/35483#discussion_r804211605
##########
File path:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/WritableColumnVector.java
##########
@@ -703,13 +720,13 @@ public WritableColumnVector arrayData() {
public abstract int getArrayOffset(int rowId);
- @Override
- public WritableColumnVector getChild(int ordinal) { return
childColumns[ordinal]; }
-
/**
- * Returns the elements appended.
+ * Returns the offset of a struct element at 'rowId' in the child vectors of
this.
*/
- public final int getElementsAppended() { return elementsAppended; }
+ public abstract int getStructOffset(int rowId);
+
+ @Override
+ public WritableColumnVector getChild(int ordinal) { return
childColumns[ordinal]; }
Review comment:
I think it's better now after revive `getElementsAppended`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
