viirya commented on a change in pull request #35483:
URL: https://github.com/apache/spark/pull/35483#discussion_r804267367
##########
File path:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/WritableColumnVector.java
##########
@@ -661,21 +671,22 @@ public final int appendArray(int length) {
* common non-struct case.
*/
public final int appendStruct(boolean isNull) {
+ reserve(elementsAppended + 1);
if (isNull) {
// This is the same as appendNull but without the assertion for struct
types
- reserve(elementsAppended + 1);
putNull(elementsAppended);
- elementsAppended++;
for (WritableColumnVector c: childColumns) {
- if (c.type instanceof StructType) {
+ if (c.isStruct()) {
c.appendStruct(true);
} else {
c.appendNull();
Review comment:
Hmm, I think the main purpose of this PR is to "avoiding allocating
space in child vectors when an element is null." Here we still call
`appendNull` which does `reserve` that will allocate more space if needed. So I
am not sure if we avoid allocating space? Or it is in other place I missed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
