sunchao commented on a change in pull request #35483:
URL: https://github.com/apache/spark/pull/35483#discussion_r804854322
##########
File path:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OffHeapColumnVector.java
##########
@@ -64,13 +64,23 @@
private long lengthData;
private long offsetData;
+ // Only set if type is Struct.
+ //
+ // A slot 'structOffsetData[i]' is only defined iff 'nulls[i]' is NOT set.
If defined,
Review comment:
I can try to revise it if it sounds confusing. How about:
> A slot 'structOffsetData[i]' will only be set iff 'nulls[i]' is NOT set.
If set, 'structOffsetData[i] = j' indicates that for struct at slot 'i', its
offset in the child vectors is 'j'. For those slots that are not set, their
values are undefined and should never be used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
