viirya commented on a change in pull request #35483:
URL: https://github.com/apache/spark/pull/35483#discussion_r804422405
##########
File path:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OffHeapColumnVector.java
##########
@@ -64,13 +64,23 @@
private long lengthData;
private long offsetData;
+ // Only set if type is Struct.
+ //
+ // A slot 'structOffsetData[i]' is only defined iff 'nulls[i]' is NOT set.
If defined,
Review comment:
actually "defined" is a bit confusing when I first read this, because it
doesn't look like we set it in "undefined" value. I guess its meaning is, if
the index i is null at this column vector, then the index of `structOffsetData`
is meaningful and will/can be used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
