srowen commented on a change in pull request #35363:
URL: https://github.com/apache/spark/pull/35363#discussion_r806907339
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/FilterEstimation.scala
##########
@@ -311,6 +311,17 @@ case class FilterEstimation(plan: Filter) extends Logging {
logDebug("[CBO] No statistics for " + attr)
return None
}
+
+ attr.dataType match {
+ case StringType | BinaryType =>
+ None
+ case _: NumericType | DateType | TimestampType | BooleanType =>
+ if (!colStatsMap.hasMinMaxStats(attr)) {
+ logDebug("[CBO] No statistics for " + attr)
Review comment:
Total nit, but use string interpolation
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/FilterEstimation.scala
##########
@@ -311,6 +311,17 @@ case class FilterEstimation(plan: Filter) extends Logging {
logDebug("[CBO] No statistics for " + attr)
return None
}
+
+ attr.dataType match {
+ case StringType | BinaryType =>
+ None
Review comment:
This doesn't seem to do anything; is it meant to be `return None`? If
it's a no-op, then it seems like this can just be omitted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
