srowen commented on a change in pull request #35363:
URL: https://github.com/apache/spark/pull/35363#discussion_r807984209
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/FilterEstimation.scala
##########
@@ -311,6 +311,16 @@ case class FilterEstimation(plan: Filter) extends Logging {
logDebug("[CBO] No statistics for " + attr)
return None
}
+
+ attr.dataType match {
+ case _: NumericType | DateType | TimestampType | BooleanType =>
+ if (!colStatsMap.hasMinMaxStats(attr)) {
+ logDebug(s"[CBO] No statistics for $attr")
+ return None
+ }
+ case StringType | BinaryType =>
Review comment:
Just `case _ => // do nothing` if you mean to do nothing otherwise? this
match would fail on other types not mentioned here otherwise
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
