Kimahriman commented on a change in pull request #35504:
URL: https://github.com/apache/spark/pull/35504#discussion_r807317733
##########
File path: core/src/main/scala/org/apache/spark/SparkConf.scala
##########
@@ -636,7 +636,9 @@ private[spark] object SparkConf extends Logging {
DeprecatedConfig("spark.blacklist.killBlacklistedExecutors", "3.1.0",
"Please use spark.excludeOnFailure.killExcludedExecutors"),
DeprecatedConfig("spark.yarn.blacklist.executor.launch.blacklisting.enabled",
"3.1.0",
- "Please use spark.yarn.executor.launch.excludeOnFailure.enabled")
+ "Please use spark.yarn.executor.launch.excludeOnFailure.enabled"),
+ DeprecatedConfig("spark.kubernetes.memoryOverheadFactor", "3.3.0",
Review comment:
Yeah the idea was if you still want to use that we will, otherwise we'll
look for the new thing, I thought that was how it was normally done, but I can
change it if I got that wrong. Not sure how to handle it since the new config
has a default value. "Use the new config if it's specifically passed, otherwise
try the old config, and if that's not there use the default value for the new
config".
Wasn't sure exactly how to handle the fact that k8s already had this as its
own setting but the other didn't.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
