Kimahriman commented on a change in pull request #35504:
URL: https://github.com/apache/spark/pull/35504#discussion_r809001068
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
##########
@@ -490,7 +490,7 @@ private[spark] object Config extends Logging {
.doubleConf
.checkValue(mem_overhead => mem_overhead >= 0,
"Ensure that memory overhead is non-negative")
- .createWithDefault(0.1)
+ .createOptional
Review comment:
Done
##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -105,6 +105,17 @@ package object config {
.bytesConf(ByteUnit.MiB)
.createOptional
+ private[spark] val DRIVER_MEMORY_OVERHEAD_FACTOR =
+ ConfigBuilder("spark.driver.memoryOverheadFactor")
+ .doc("The amount of non-heap memory to be allocated per driver in
cluster mode, " +
+ "as a fraction of total driver memory. If memory overhead is specified
directly, " +
+ "it takes precedence.")
+ .version("3.3.0")
+ .doubleConf
+ .checkValue(factor => factor >= 0 && factor < 1,
+ "Ensure that memory overhead is a double between 0 --> 1.0")
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
