cloud-fan commented on a change in pull request #35533:
URL: https://github.com/apache/spark/pull/35533#discussion_r808006760
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
##########
@@ -2565,15 +2565,14 @@ case class ToBinary(expr: Expression, format:
Option[Expression], child: Express
case lit if lit.foldable =>
Review comment:
I'd put the string type check here, as `to_binary(str_col, cast(null as
int))` should fail instead of returning null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
