cloud-fan commented on a change in pull request #35533:
URL: https://github.com/apache/spark/pull/35533#discussion_r808830812
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
##########
@@ -2562,18 +2562,17 @@ case class ToBinary(expr: Expression, format:
Option[Expression], child: Express
def this(expr: Expression, format: Expression) = this(expr, Option(format),
format match {
- case lit if lit.foldable =>
+ case lit if (lit.foldable && Seq(StringType,
NullType).contains(lit.dataType)) =>
Review comment:
BTW, do other systems like snowflake support `to_binary('abc', null)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
