nyingping commented on a change in pull request #35526:
URL: https://github.com/apache/spark/pull/35526#discussion_r808588658
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameTimeWindowingSuite.scala
##########
@@ -490,4 +490,81 @@ class DataFrameTimeWindowingSuite extends QueryTest with
SharedSparkSession {
assert(attributeReference.dataType == tuple._2)
}
}
+
+ test("No need to filter data when the sliding window length is not
redundant") {
+ // check the value column
+ val df1 = Seq(
+ ("2022-02-15 19:39:34", 1, "a"),
+ ("2022-02-15 19:39:56", 2, "a"),
+ ("2022-02-15 19:39:27", 4, "b")).toDF("time", "value", "id")
+ .select(window($"time", "9 seconds", "3 seconds", "0 second"), $"value")
+ .orderBy($"window.start".asc, $"value".desc).select("value")
+ val df2 = Seq(
+ (LocalDateTime.parse("2022-02-15T19:39:34"), 1, "a"),
+ (LocalDateTime.parse("2022-02-15T19:39:56"), 2, "a"),
+ (LocalDateTime.parse("2022-02-15T19:39:27"), 4, "b")).toDF("time",
"value", "id")
+ .select(window($"time", "9 seconds", "3 seconds", "0 second"), $"value")
+ .orderBy($"window.start".asc, $"value".desc).select("value")
+
+ val df3 = Seq(
+ ("2022-02-15 19:39:34", 1, "a"),
+ ("2022-02-15 19:39:56", 2, "a"),
+ ("2022-02-15 19:39:27", 4, "b")).toDF("time", "value", "id")
+ .select(window($"time", "9 seconds", "3 seconds", "-2 second"), $"value")
+ .orderBy($"window.start".asc, $"value".desc).select("value")
+ val df4 = Seq(
+ (LocalDateTime.parse("2022-02-15T19:39:34"), 1, "a"),
+ (LocalDateTime.parse("2022-02-15T19:39:56"), 2, "a"),
+ (LocalDateTime.parse("2022-02-15T19:39:27"), 4, "b")).toDF("time",
"value", "id")
+ .select(window($"time", "9 seconds", "3 seconds", "2 second"), $"value")
+ .orderBy($"window.start".asc, $"value".desc).select("value")
+
+ Seq(df1, df2).foreach { df =>
+ val filter = df.queryExecution.optimizedPlan.find(_.isInstanceOf[Filter])
+ val exist = filter.get.constraints.iterator.toStream.filter(e =>
+ e.toString.contains(">=") || e.toString.contains("<"))
+ assert(exist.isEmpty, "No need to filter data between " +
+ "window.start and window.end when the sliding window length is not
redundant")
Review comment:
I agree that "`redundant`" is a poor description, How about "`No need to
filter data when the windowDuration of a sliding window is an integer multiple
of slideDuration`" or `"No need to filter data when when windowDuration is
multiple of slideDuration for sliding windows"` instead? If this is accurate
enough, I can use it to replace the name of the test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
