HeartSaVioR commented on a change in pull request #35526:
URL: https://github.com/apache/spark/pull/35526#discussion_r808699368
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameTimeWindowingSuite.scala
##########
@@ -521,7 +521,7 @@ class DataFrameTimeWindowingSuite extends QueryTest with
SharedSparkSession {
Seq(df1, df2, df3, df4).foreach { df =>
val filter = df.queryExecution.optimizedPlan.find(_.isInstanceOf[Filter])
assert(filter.isDefined)
- val exist = filter.get.constraints.filter(e =>
+ val exist = filter.get.constraints.filter( e =>
Review comment:
nit: Previous was correct based on style guide. please refer below
guidance:
https://github.com/databricks/scala-style-guide#anonymous-methods
When you use parentheses for anonymous method, no space. When you use curly
braces for anonymous method, space.
For multi-lines we prefer using curly braces, like
```
val exist = filter.get.constraints.filter { e =>
e.toString.contains(">=") || e.toString.contains("<")
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
