cloud-fan commented on a change in pull request #35473: URL: https://github.com/apache/spark/pull/35473#discussion_r811610570
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/OptimizeOneRowPlan.scala ########## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst.optimizer + +import org.apache.spark.sql.catalyst.expressions.aggregate._ +import org.apache.spark.sql.catalyst.plans.logical._ +import org.apache.spark.sql.catalyst.rules._ +import org.apache.spark.sql.catalyst.trees.TreePattern._ + +/** + * The rule is applied both normal and AQE Optimizer. It optimizes plan using max rows: + * - if the max rows of the child of sort less than or equal to 1, remove the sort + * - if the max rows per partition of the child of local sort less than or equal to 1, + * remove the local sort + * - if the max rows of the child of aggregate less than or equal to 1 and its child and + * it's grouping only(include the rewritten distinct plan), convert aggregate to project + * - if the max rows of the child of aggregate less than or equal to 1, + * set distinct to false in all aggregate expression + */ +object OptimizeOneRowPlan extends Rule[LogicalPlan] { + private def maxRowNotLargerThanOne(plan: LogicalPlan): Boolean = { + plan.maxRows.exists(_ <= 1L) Review comment: Seems the code itself is simple and clean, we don't need to create a method for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
