HeartSaVioR commented on a change in pull request #35574:
URL: https://github.com/apache/spark/pull/35574#discussion_r813457028
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala
##########
@@ -72,10 +72,15 @@ case object AllTuples extends Distribution {
/**
* Represents data where tuples that share the same values for the `clustering`
* [[Expression Expressions]] will be co-located in the same partition.
+ *
+ * @param requiredAllClusterKeys When true, `Partitioning` which satisfies
this distribution,
+ * must match all `clustering` expressions in
the same ordering.
*/
case class ClusteredDistribution(
clustering: Seq[Expression],
- requiredNumPartitions: Option[Int] = None) extends Distribution {
+ requiredNumPartitions: Option[Int] = None,
+ requiredAllClusterKeys: Boolean = SQLConf.get.getConf(
Review comment:
I just wanted to make sure the config value we override in
IncrementalExecution is in effect here with singleton SQLConf approach.
Otherwise we will encounter the problem. (So we prevent the case in the PR, and
we have to make sure the safeguard takes effect all of the time.)
For co-partition case, I guess stream-stream join is only the case for
streaming (I might not be exhaustive, but at least probably exhaustive for
stateful operators) and we use StatefulOpClusteredDistribution directly so it
seems OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
