c21 commented on a change in pull request #35574:
URL: https://github.com/apache/spark/pull/35574#discussion_r813494393
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala
##########
@@ -1453,6 +1455,57 @@ class DataFrameAggregateSuite extends QueryTest
val df = Seq(1).toDF("id").groupBy(Stream($"id" + 1, $"id" + 2):
_*).sum("id")
checkAnswer(df, Row(2, 3, 1))
}
+
+ test("SPARK-38237: require all cluster keys for child required
distribution") {
+ def partitionExpressionsColumns(expressions: Seq[Expression]): Seq[String]
= {
+ expressions.flatMap {
+ case ref: AttributeReference => Some(ref.name)
+ }
+ }
+
+ def isShuffleExecByRequirement(
+ plan: ShuffleExchangeExec,
+ desiredClusterColumns: Seq[String],
+ desiredNumPartitions: Int): Boolean = plan match {
Review comment:
@cloud-fan - I think we don't need to check number of partitions here,
unless @HeartSaVioR do you have a strong opinion on this? Removed it for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
