sunchao commented on a change in pull request #35574:
URL: https://github.com/apache/spark/pull/35574#discussion_r813494914
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala
##########
@@ -72,10 +72,15 @@ case object AllTuples extends Distribution {
/**
* Represents data where tuples that share the same values for the `clustering`
* [[Expression Expressions]] will be co-located in the same partition.
+ *
+ * @param requiredAllClusterKeys When true, `Partitioning` which satisfies
this distribution,
+ * must match all `clustering` expressions in
the same ordering.
*/
case class ClusteredDistribution(
clustering: Seq[Expression],
- requiredNumPartitions: Option[Int] = None) extends Distribution {
+ requiredNumPartitions: Option[Int] = None,
+ requiredAllClusterKeys: Boolean = SQLConf.get.getConf(
Review comment:
I think we should call this `requireAllClusterKeys`?
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala
##########
@@ -88,6 +93,19 @@ case class ClusteredDistribution(
s"the actual number of partitions is $numPartitions.")
HashPartitioning(clustering, numPartitions)
}
+
+ /**
+ * Checks if `expressions` match all `clustering` expressions in the same
ordering.
+ *
+ * `Partitioning` should call this to check its expressions when
`requiredAllClusterKeys`
+ * is set to true.
+ */
+ def areAllClusterKeysMatched(expressions: Seq[Expression]): Boolean = {
+ expressions.length == clustering.length &&
+ expressions.zip(clustering).forall {
Review comment:
For aggregate or window, I'm not sure whether we have any reordering
mechanism similar to join. If not, this could be very limited?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
