MaxGekk commented on a change in pull request #35656:
URL: https://github.com/apache/spark/pull/35656#discussion_r815633479
##########
File path: core/src/main/resources/error/error-classes.json
##########
@@ -152,6 +155,12 @@
"UNSUPPORTED_GROUPING_EXPRESSION" : {
"message" : [ "grouping()/grouping_id() can only be used with
GroupingSets/Cube/Rollup" ]
},
+ "UNSUPPORTED_JOIN_CONDITION" : {
+ "message" : [ "Using PythonUDF in join condition of join type %s is not
supported" ]
+ },
+ "UNSUPPORTED_PANDAS_UDF_AGGREGATE_EXPRESSION" : {
+ "message" : [ "Pandas UDF aggregate expressions don't support pivot." ]
+ },
Review comment:
Can't you re-use the existing error class `UNSUPPORTED_FEATURE`?
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/errors/QueryCompilationErrorsSuite.scala
##########
@@ -101,4 +101,67 @@ class QueryCompilationErrorsSuite extends QueryTest with
SharedSparkSession {
assert(e.message ===
"The argument_index of string format cannot contain position 0$.")
}
+
+ test("CANNOT_USE_MIXTURE") {
Review comment:
Please, look at other test titles. They contain an error class and some
message which explain what the particular test checks. Could you add some
message here (and below tests) too, please.
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala
##########
@@ -373,7 +373,8 @@ abstract class SparkStrategies extends
QueryPlanner[SparkPlan] {
namedGroupingExpressions, aggregateExpressions,
rewrittenResultExpressions, child) =>
if (aggregateExpressions.exists(PythonUDF.isGroupedAggPandasUDF)) {
- throw
QueryCompilationErrors.groupAggPandasUDFUnsupportedByStreamingAggError()
+ throw new AnalysisException(
+ "Streaming aggregation doesn't support group aggregate pandas UDF")
Review comment:
Could you clarify why did you make this replacement?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
