itholic commented on a change in pull request #35656:
URL: https://github.com/apache/spark/pull/35656#discussion_r817170583



##########
File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala
##########
@@ -373,7 +373,8 @@ abstract class SparkStrategies extends 
QueryPlanner[SparkPlan] {
         namedGroupingExpressions, aggregateExpressions, 
rewrittenResultExpressions, child) =>
 
         if (aggregateExpressions.exists(PythonUDF.isGroupedAggPandasUDF)) {
-          throw 
QueryCompilationErrors.groupAggPandasUDFUnsupportedByStreamingAggError()
+          throw new AnalysisException(
+            "Streaming aggregation doesn't support group aggregate pandas UDF")

Review comment:
       Because the existing `groupAggPandasUDFUnsupportedByStreamingAggError` 
is not user-facing error, so I firstly remove it from `QueryCompilationErrors` 
since I think maybe we don't want to reveal the non-user-facing error to the 
error class.
   
   And, also refer to 
https://github.com/apache/spark/pull/35656/files#r814517495.
   
   Btw, maybe do we also want to leave some comment to the code base?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to