HyukjinKwon commented on a change in pull request #35735:
URL: https://github.com/apache/spark/pull/35735#discussion_r820309557



##########
File path: sql/core/src/test/resources/sql-tests/results/group-by.sql.out
##########
@@ -708,9 +708,112 @@ FROM VALUES
  (31), (32), (33), (34), (35), (3), (37), (38), (39), (40),
  (41), (42), (43), (44), (45), (46), (47), (48), (49), (50) AS tab(col)
 -- !query schema
-struct<histogram_2:array<struct<x:double,y:double>>,histogram_3:array<struct<x:double,y:double>>,histogram_5:array<struct<x:double,y:double>>,histogram_10:array<struct<x:double,y:double>>>
+struct<histogram_2:array<struct<x:int,y:double>>,histogram_3:array<struct<x:int,y:double>>,histogram_5:array<struct<x:int,y:double>>,histogram_10:array<struct<x:int,y:double>>>

Review comment:
       I guess the double value behaivour is from 
[Hive's](https://cwiki.apache.org/confluence/display/hive/languagemanual+udf) 
while I like it to match the input type. I think we should have a switch to 
turn on and off this behaviour.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to