cloud-fan commented on a change in pull request #35735:
URL: https://github.com/apache/spark/pull/35735#discussion_r821292735
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/HistogramNumeric.scala
##########
@@ -46,7 +47,10 @@ import org.apache.spark.sql.util.NumericHistogram
smaller datasets. Note that this function creates a histogram with
non-uniform
bin widths. It offers no guarantees in terms of the mean-squared-error
of the
histogram, but in practice is comparable to the histograms produced by
the R/S-Plus
- statistical computing packages.
+ statistical computing packages. Note: if
+ SQLConf.spark.sql.legacy.histogramNumericPropagateInputType is set to
true, the output type
Review comment:
Let's not mention the legacy config as it's internal and only for users
who have problems migrating to new Spark versions. Let's just document the new
behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
